chore(target_chains/fuel): update fuel packages

pyth-network / pyth-crosschain

Crosschain Pyth programs and utilities

https://pyth.network

Other

144 stars 195 forks source link

chore(target_chains/fuel): update fuel packages #1837

Closed martines3000 closed 1 month ago

martines3000 commented 2 months ago

This PR update fuel package versions for the Pyth Fuel JS SDK and the contracts project.

I added rust target wasm32-unknown-unknown as without it cargo build and test commands fail.
Slight implementation changes were made inside contract_manager/src/contracts/fuel. Without the changes the build process failed.

vercel[bot] commented 2 months ago

@martines3000 is attempting to deploy a commit to the pyth-web Team on Vercel.

A member of the Team first needs to authorize it.

martines3000 commented 2 months ago

@cctdaniel @ali-bahjati Please feel free to suggest/implement any changes you think are necessary.

cctdaniel commented 1 month ago

hi! thanks for your contribution, it seems like no test cases were ran with this change which seems odd, do you mind taking another look at it?

martines3000 commented 1 month ago

Hi @cctdaniel.

cargo test was successful
For the forc test --verbose command I looked at your other CI runs and there are also no tests run when it is executed. (Example 1 and Example 2)

cctdaniel commented 1 month ago

I see, thanks for pointing out the issue, we should have ran cargo test instead of forc test

martines3000 commented 1 month ago

I looked at the documentation and forc test is a wrapper around cargo test, but I am not sure why it doesn't run anything. In my opinion, running forc build, cargo test and cargo build is enough to verify everything works as expected.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment