pyth-network / pyth-crosschain

Crosschain Pyth programs and utilities
https://pyth.network
Other
144 stars 195 forks source link

fix(staking): localize numbers & dates the best English variant #1985

Closed cprussin closed 2 weeks ago

cprussin commented 2 weeks ago

Previously, all numbers, dates, sorting, etc was localized to the browser's preferred locale.

However, we don't have copy translated so it was confusing to see localized characters in some places but unlocalized text.

This PR changes things so that we localize numbers, dates, sorting, etc to the first English variant in the browser's preferred locales list. That way, we can at least localize formats to the user's preference, but don't localize any text and everything consistently shows up in English.

vercel[bot] commented 2 weeks ago

@cprussin is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:52pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:52pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **proposals** | ⬜️ Ignored ([Inspect](https://vercel.com/pyth-network/proposals/FxV5RUJmWL6rkLseagzu5vcEUTBp)) | [Visit Preview](https://proposals-git-fork-cprussin-dont-localize-numbers-pyth-network.vercel.app) | | Oct 1, 2024 11:52pm |