pythian / opsviz

25 stars 24 forks source link

Feature/multi az #69

Closed lesaux closed 9 years ago

lesaux commented 9 years ago

This is not the most elegant, but it creates 4 private subnets in different AZ to be used by the stack. It begins to address https://github.com/pythian/opsviz/issues/51.

Private ELBs are configured to use these private subnets. The initial elasticsearch instances are spanned across these as well.

This will be used to further implement auto-scaling features for several of the components.

Warnings: 1)The cloudformation.json file will be larger than 51000 bytes, thus requiring it to be stored in S3 to launch the stack. 2)Some properties have been renamed so this is likely to break any cfn "update-stack" features.

pdehlke commented 9 years ago

I like this a lot so far, but it's only working in us-east-1, since that's the only region with four Azs. The Fn::Select statements in the Subnet definitions should likely be indexed from 0-2 instead of 1-3, no?

lesaux commented 9 years ago

You are completely correct about the indexes! good catch. And we don't really need 4 AZ anyways, 3 should be enough. I'll make those changes very shortly. Thanks!

lesaux commented 9 years ago

I am removing PrivateSubnet3 - and I'm seeing correct indexes no?

PrivateSubnet0 Fn::Select "0"
PrivateSubnet1 Fn::Select "1"
PrivateSubnet2 Fn::Select "2"

no?