timothy1ee
commented
9 years ago Wow, exceptional work! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. When I'm auditing the code, I use the checklist below. If you didn't do one of the items below, you should consider implementing it.
- Code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- Minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
- When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
- The images should be downloaded asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
- Observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- This week, we'll cover how to use Auto Layout constraints to implement dynamic height rows and adjust to synopsis of different length.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
My app is complete, please review, thanks in advance! /cc @codepathreview