GUI Improvements - Githubissues

python-20 / video-downloader

A python application to download videos

GNU General Public License v3.0

9 stars 10 forks source link

GUI Improvements #11

Closed cherylli closed 4 years ago

cherylli commented 4 years ago

[x] Add a popup to choose download location - how to add a file selector
[x] Default Image if no image
[x] Error Display - Popup/Red bar underneath
[x] Resolution set to last resolution downloaded, if not highest by default- Similar issue
[ ] Also possibly sort the drop down menu by media type, then by resolution,

more to add @RyanSamman

chonix commented 4 years ago

[x] Resolution set to highest by default Perhaps error display can be added as a textbox in the GUI or is that a bad practice?

cherylli commented 4 years ago

we can make a textbox for error. so maybe a text box which says something along the line of "ok"/"pass", if there's no error then display the error if there's any?

RyanSamman commented 4 years ago

I have an idea, we can make a labels to get:

video Length YouTube.length,
Rating YouTube.rating
Views
Description, get the first like 40 characters then add some ...

Make it into one function 😡 no need to make 50 functions to do this

We might also want to prefetch in the API

Also, for the loading bar, this and the one under it may be useful: https://python-pytube.readthedocs.io/en/latest/api.html#pytube.YouTube.register_on_complete_callback https://python-pytube.readthedocs.io/en/latest/api.html#pytube.Stream.on_progress

RyanSamman commented 4 years ago

Moved the stuff remaining to #39 to keep it all in one spot