python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
9 stars 10 forks source link

Backend: Code fixing #21

Closed RyanSamman closed 4 years ago

RyanSamman commented 4 years ago

(I'll probably do some of this on my own but)

RyanSamman commented 4 years ago

The bug and download error was fixed by removing the indentation

cherylli commented 4 years ago

Just FYI: TO add window icon :

What do you mean by

Possibly refactor the "getYouTubeVideoTitle" method in class "YouTubeVideo"

Add more logging, log file, and add a variable on the top to toggle what messages are showing

Already exist logging.basicConfig(level=logging.INFO) change this line, check out https://docs.python.org/3/howto/logging.html

Add a comment in the top/bottom of the file listing and describing all the GUI components, to make it easier to use and understand possibly in anther file like the project wiki page since it will be way too long to include in the code

RyanSamman commented 4 years ago

Possibly refactor the "getYouTubeVideoTitle" method in class "YouTubeVideo"

I mean, use a more intuitive and shorter name than getYouTubeVideoTitle becauseItsHardToWriteAndReadAndItIsNotMoreDescriptiveWhenYouMakeItLonger

Add more logging, log file, and add a variable on the top to toggle what messages are showing

I'll have to look into proper logging practices more, but we can possibly add some tkinter to the code to make popups to show error information

Add a comment in the top/bottom of the file listing and describing all the GUI components, to make it easier to use and understand

Backend people don't know the frontend widgets and code unless they open QTDesigner, it will be much easier to know what to do if you made a comment on the bottom describing all the widgets (buttons, entry boxes, relavent labels, tabs etc) in the frontend, what they are and what we can do with them (Attach commands, push text into them, etc),

possibly in anther file like the project wiki page since it will be way too long to include in the code

Yeah on second thought, we can just add a link to the wiki page in the bottom of our program

cherylli commented 4 years ago

Is everything good now?