search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
10 stars 10 forks source link

Migrate from Venv to Pipenv #31

Closed RyanSamman closed 4 years ago

RyanSamman commented 4 years ago

I have heard that PipEnv, combining both pip and venv to have a similar functionality as npm in JavaScript

Another article comparing pipenv and venv

RyanSamman commented 4 years ago

The point is to change it while it is working, not while it isn't

chonix commented 4 years ago

using any virtual environment shouldn't affect the project as long as you mantain correctly the .gitignore file. You see I could be using whichever virtual environment or not, just directly using the system binaries.

This doesn't affect the end user nor the project. Just your choice of how to install modules for your pythin version

chonix commented 4 years ago

Sorry, was on mobile and mispressed the close button. Didnt mean to do it.

cherylli commented 4 years ago

Yes you're right there's not really any reference of virtual environment in our project. So it shouldn't matter which one you use. You don't even need one, if you don't want to!

chonix commented 4 years ago

@RyanSamman . You ok if we close this?

RyanSamman commented 4 years ago

I'll close it for now, not an issue short term but if something changes everything will break