search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
9 stars 10 forks source link

Change pyqt.py to gui.py #46

Closed AlexPHorta closed 4 years ago

AlexPHorta commented 4 years ago

Let's avoid potential name clashes.

cherylli commented 4 years ago

Yes that file needs a rename for sure but gui.py may or may not be suitable when we have multiple window for future for playlists and sources other than YouTube. Do we just put everything in the same file? If we use a tabbed window is that still the same .ui file?

RyanSamman commented 4 years ago

It will be in the same UI file for all sources, yes tabbed windows are the same .ui file

cherylli commented 4 years ago

Yeah that's fine go ahead and rename it. I've meant to rename it for a while. It started as a test file for pyqt when we were deciding what GUI thing to use

cherylli commented 4 years ago

I've changed the name in the latest pull request