search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
10 stars 10 forks source link

Popup for correct url #48

Closed barguan closed 4 years ago

barguan commented 4 years ago

Gives a pop-up to ask for correct URL. The GUI looks like it just freezes if an incompatible URL is input. This will work for now until playlists/other sources to download from are implemented. Would need a different string for playlists to check if its correct.

cherylli commented 4 years ago

Just updated a few things. I think it would be better to use regex to match a valid URL. For example. now "www.youtube.com/watch?" or anything containing the phrase will still be considered a valid input

cherylli commented 4 years ago

Found this: Regex for youtube URL

RyanSamman commented 4 years ago

No offense but i think my PR #51 is a better way to handle the error, you might want to look at it

AlexPHorta commented 4 years ago

barguan, I think Ryan has a better approach for this issue, it tackles other kinds of error and leave room to easy insertion of other situations we stumble upon. I'll take his pull request, ok?

(Copying it here, don't know if it will remain buried in the rest of the conversation.)

cherylli commented 4 years ago

closed as alternative approach was applied