search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
10 stars 10 forks source link

Feature/combobox #56

Closed cherylli closed 4 years ago

cherylli commented 4 years ago

now only supports progressive stream and audio download

cherylli commented 4 years ago

Hello all. Please review. Now only supports progressive and audio download, as discussed #45 New features include:

Bug fix: Disable download button before URL is processed

Enhancement: Pressing enter on URL line edit triggers EnterURL function

chonix commented 4 years ago

Found an issue which I can't reproduce. First thing I did was fetch this pull's code.

After playing a bit with the comboboxes and stuff, I received an "https://www.youtube.com/watch?v=D8fbPecM9TY is an invalid URL"

where I believe the url had wrapped up some set of double quotes around it.

Will play a bit more and get back to it.

AlexPHorta commented 4 years ago

I took a shot with another video, one of those that are basically music and a static picture (the artwork of the album). Here's what happened:

  1. After pressing OK, the screen freezes for a moment, and then the thumbnail appears.

Video Downloader_002

  1. Then, this list appears in the combobox:

Video Downloader_003

  1. After that, I closed the program and reopened it. I reloaded the same URL. Now, this list appears in the combobox:

Video Downloader_004

  1. I downloaded the biggest quality available. The same behaviour I mentioned earlier happened. The first download took forever to finish. The second one (the audio), is faster, but reaches 100% and never finishes.

Video Downloader_005

cherylli commented 4 years ago

Wait how come you don't have the checkboxes. Looks like your version is not up to date. Did you pull the latest?

cherylli commented 4 years ago

It should look like this now

AlexPHorta commented 4 years ago

Wait how come you don't have the checkboxes. Looks like your version is not up to date. Did you pull the latest?

My fault, it was not updated. Did I tell you I need a course on git?

AlexPHorta commented 4 years ago

But it still reaches 100% and never ends the download anyway.

cherylli commented 4 years ago

never ends the download as in the file is not there or corrupted or ? Or is it just no pop up shown? I temporary disabled the pop up as I want to move it to somewhere after all these current pull requests are dealt with. If you noticed I have removed download function in gui and just use the download in core. So i need to find somewhere to put the pop up

Sorry doesn't happen here so I want to know more details

AlexPHorta commented 4 years ago

never ends the download as in the file is not there or corrupted or ? Or is it just no pop up shown? I temporary disabled the pop up as I want to move it to somewhere after all these current pull requests are dealt with. If you noticed I have removed download function in gui and just use the download in core. So i need to find somewhere to put the pop up

Sorry doesn't happen here so I want to know more details

Ah, ok, the download is fine.

In my opinion, move the popUp method to the end of the gui class. Showing popups is a gui's duty.

chonix commented 4 years ago

This is kind of a flaw. If I approve, and there's still old approve from @RyanSamman (before changes), it'll still merge. Can we look onto this?

cherylli commented 4 years ago

what flaw are you refering to @chonix ?

chonix commented 4 years ago

@cherylli : Ryan approved before some typo and corrections. Is that still a "valid" review? Approvals should reset if a new commit is added.

cherylli commented 4 years ago

It does reset sometimes, but I don't know why it doesn't always. He probably just missed them haha, it happens its kind of a long and big pull requests

cherylli commented 4 years ago

I think you have to manually re-request review. Also it doesn't get merged automatically you still need to manually merge but the merge button will be enabled.