python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
10 stars 10 forks source link

Ryan's testing branch #61

Open RyanSamman opened 4 years ago

RyanSamman commented 4 years ago

Take a look at my changes c:

I merged all the current PRs into this one (#56 #57 #58 #59), and resolved all merge conflicts, and of course tested the code.

There is a slight problem across all branches I've tested, when you press OK in the GUI, it takes ages to download, Even after switching to pytube v3.6.

cherylli commented 4 years ago

Please no. I hope this is a joke. Don't merge different pull requests into a single pull request

chonix commented 4 years ago

Err.... I like the initiative, but many merges for improvements. Please do keep it simple. One improvement, one PR.