search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
10 stars 10 forks source link

Update pytube3 dependency to 9.6.3 #68

Closed RyanSamman closed 4 years ago

RyanSamman commented 4 years ago

The current version of pytube3 which we are using, 9.5.11, may be outdated, so I'd suggest moving the version on requirements.txt on to the current version, 9.6.2.

chonix commented 4 years ago

9.5.11 is way outdated, there have been a lot of bug fixes and speed upgrades to pytube since. Whether we want exactly 9.6.2 or any version above can be debated.

"9.5.11 is outdated, I propose to upgrade the version to 9.6.2. I've checked out in my local environment, and so far I had no issues"

Yeah I like that. However, what about this? https://dependabot.com/

cherylli commented 4 years ago

It needs to include the pr which was merged today for the download speed improvement for adaptive stream https://github.com/hbmartin/pytube3/pull/61

RyanSamman commented 4 years ago

You are right @cherylli, I thought the sticker in the readme.txt had the most recent version, my bad

chonix commented 4 years ago

Closing as #69 is the main bump for it.