search

python-20 / video-downloader

A python application to download videos
GNU General Public License v3.0
9 stars 10 forks source link

Feature/load url function #73

Closed AlexPHorta closed 4 years ago

AlexPHorta commented 4 years ago

Hi, people. Added a shortcut to load the default url to the text box, instead of placing the url directly inside the box. The shortcut is Ctrl+Shift+U. This way the program looks more 'production' ready.

cherylli commented 4 years ago

Nice didn't know you can use a shortcut to do it. I was always going to remove it when it moves out of development phase. I'll probably still prefer preloading it during development but that's just me 🤣

AlexPHorta commented 4 years ago

Nice didn't know you can use a shortcut to do it. I was always going to remove it when it moves out of development phase. I'll probably still prefer preloading it during development but that's just me rofl

Feel free to not approve, it's just that it bugs me. I like the cleaner interface. Mr clean. Ahahah!

cherylli commented 4 years ago

We can just remove or comment out the line? as I don't think a default url will be needed after the development phase? What do you think.

AlexPHorta commented 4 years ago

We can just remove or comment out the line? as I don't think a default url will be needed after the development phase? What do you think.

It's easy, just remove the shortcut definition. I placed the default text in the ui file. It's a really small PR to remove everything.

Good thing is, we now know how to add shortcuts!

cherylli commented 4 years ago

True i'll check it out later tonight , let me check out my current branch first

AlexPHorta commented 4 years ago

Traceback (most recent call last): File "youtubedl/gui.py", line 180, in window = Ui() File "youtubedl/gui.py", line 20, in init uic.loadUi(f'{appPath}/ui/qt.ui', self) File "/home/alexandre/P3/lib/python3.6/site-packages/PyQt5/uic/init.py", line 237, in loadUi return DynamicUILoader(package).loadUi(uifile, baseinstance, resource_suffix) File "/home/alexandre/P3/lib/python3.6/site-packages/PyQt5/uic/Loader/loader.py", line 66, in loadUi return self.parse(filename, resource_suffix) File "/home/alexandre/P3/lib/python3.6/site-packages/PyQt5/uic/uiparser.py", line 1020, in parse document = parse(filename) File "/usr/lib/python3.6/xml/etree/ElementTree.py", line 1196, in parse tree.parse(source, parser) File "/usr/lib/python3.6/xml/etree/ElementTree.py", line 597, in parse self._root = parser._parse_whole(source) xml.etree.ElementTree.ParseError: mismatched tag: line 481, column 9

I believe I merged everything necessary, and I get this error. Is it ok for now? Intended? I mean, just to save the PR?

cherylli commented 4 years ago

Let me try and see if I get error tonight

cherylli commented 4 years ago

no error here.