search

python-arq / arq

Fast job queuing and RPC in python with asyncio and redis.
https://arq-docs.helpmanual.io/
MIT License
2.15k stars 174 forks source link

feat: Allow additional redis args #445

Closed aquamatthias closed 4 months ago

aquamatthias commented 6 months ago

Hi,

we use arq in https://github.com/someengineering/fixbackend - thanks for a great library. We are missing an option to provide redis settings unavailable in arq RedisSettings. One example would be: health_check_interval.

This PR would allow the arguments to be passed when the pool is created.

codecov[bot] commented 6 months ago

Codecov Report

Merging #445 (cab6f1e) into main (94cd878) will increase coverage by 0.19%. Report is 10 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ========================================== + Coverage 96.27% 96.47% +0.19% ========================================== Files 11 11 Lines 1074 1078 +4 Branches 209 190 -19 ========================================== + Hits 1034 1040 +6 Misses 19 19 + Partials 21 19 -2 ``` | [Files](https://app.codecov.io/gh/samuelcolvin/arq/pull/445?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin) | Coverage Δ | | |---|---|---| | [arq/connections.py](https://app.codecov.io/gh/samuelcolvin/arq/pull/445?src=pr&el=tree&filepath=arq%2Fconnections.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin#diff-YXJxL2Nvbm5lY3Rpb25zLnB5) | `89.93% <ø> (-0.13%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/samuelcolvin/arq/pull/445?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/samuelcolvin/arq/pull/445?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). Last update [9d7944b...cab6f1e](https://app.codecov.io/gh/samuelcolvin/arq/pull/445?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin).