search

python-astrodynamics / astrodynamics

http://www.python-astrodynamics.org
33 stars 6 forks source link

[RFC] Add jplephem based ephemeris. #9

Closed helgee closed 8 years ago

helgee commented 8 years ago

See previous discussion in #7.

helgee commented 8 years ago

Building networkx with 3.X on Windows seems to fail due to some missing example file (!) :-1:

RazerM commented 8 years ago

Odd. The file is present in git, I don't know what is causing the error. Perhaps some bug in install_data command.

RazerM commented 8 years ago

I found the issue: https://github.com/networkx/networkx/pull/1707

I think we're waiting on v1.10.1

helgee commented 8 years ago

Should we use the dev version of networkx for now? I am actually using just a single function but might need it in another place as well.

codecov-io commented 8 years ago

Current coverage is 90.65%

Merging #9 into master will decrease coverage by -9.35% as of f8fdbe7

@@            master      #9   diff @@
======================================
  Files           17      20     +3
  Stmts          463     599   +136
  Branches        28      39    +11
  Methods          0       0       
======================================
+ Hit            463     543    +80
- Partial          0      20    +20
- Missed           0      36    +36

Review entire Coverage Diff as of f8fdbe7

Powered by Codecov. Updated on successful CI builds.

RazerM commented 8 years ago

networkx issue is gone now

helgee commented 8 years ago

Ready to merge, then?

RazerM commented 8 years ago

:+1: