python-attrs / attrs

Python Classes Without Boilerplate
https://www.attrs.org/
MIT License
5.23k stars 364 forks source link

Add "resolve_types" argument to attrs.define() #1286

Open sscherfke opened 3 months ago

sscherfke commented 3 months ago

Add a resolve_types: bool = ? argument to attrs.define() and call resolve_types() on the new class if True is passed.

Why?

According to the Typed Settings issue tracker, people seem to start playing with postponed annotations. For Typed Settings to work, annotated types need to be resolved. We try to automatically do this but it is not always possible to do it. So people need to do sth. like this:

@attrs.resolve_types
@attrs.define
class Settings:
    opt: int = 0

It would be a bit nicer if they could write

@attrs.define(resolve_types=True)
class Settings:
    opt: int = 0

instead. This would also make it easier to write custom define() partials similar to frozen().

I can create a PR if needed.

sscherfke commented 3 months ago

Pydantic automatically does this so I guess users might eventually expected this behavior from attrs, too.

hynek commented 1 month ago

I'm open to PRs!