search

python-attrs / cattrs

Composable custom class converters for attrs, dataclasses and friends.
https://catt.rs
MIT License
799 stars 111 forks source link

Fix type checker error #378

Closed layday closed 1 year ago

layday commented 1 year ago

Pyright expects typing.Type to be parameterised and reports that the function's type is unknown.

codecov-commenter commented 1 year ago

Codecov Report

Merging #378 (5940921) into main (dedd72d) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files          26       26           
  Lines        2121     2121           
=======================================
  Hits         2032     2032           
  Misses         89       89
Impacted Files Coverage Δ
src/cattrs/v.py 91.66% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Tinche commented 1 year ago

LGTM, let's just add a small changelog snippet.

Tinche commented 1 year ago

Thanks!