python-attrs / cattrs

Composable custom class converters for attrs, dataclasses and friends.
https://catt.rs
MIT License
799 stars 111 forks source link

Don't cancel all jobs in CI if one job fails #386

Closed AlexWaygood closed 1 year ago

AlexWaygood commented 1 year ago

This will make it easier to see in #384 which tests (if any) are actually failing on which Python versions -- currently the codecov failures are just leading to all jobs being cancelled in CI

codecov-commenter commented 1 year ago

Codecov Report

Merging #386 (e73c8de) into main (4ad09bc) will increase coverage by 2.64%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   86.28%   88.92%   +2.64%     
==========================================
  Files          26       26              
  Lines        2121     2122       +1     
==========================================
+ Hits         1830     1887      +57     
+ Misses        291      235      -56     

see 8 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Tinche commented 1 year ago

Thanks!