python-attrs / cattrs

Composable custom class converters for attrs, dataclasses and friends.
https://catt.rs
MIT License
791 stars 110 forks source link

Use the un-underscored name if no alias attribute is there. #416

Closed jap closed 11 months ago

jap commented 1 year ago

This appears to be caused by a thinko in #391, this fixes it again.

Tinche commented 1 year ago

Ah, cool. Can you add a changelog note? And a simple test would be great so it doesn't happen again.

jap commented 1 year ago

Actually -- given that cattrs depends on modern attrs and this is just compat code, let me simplify it!

Tinche commented 12 months ago

Howdy, any progress on this? Trying to plan the next release.

jap commented 12 months ago

Whoops, sorry - forgot about this PR, working on an updated version now!

Tinche commented 11 months ago

Just a small note, I'll be away for the next 3 weeks on a family trip and I can continue reviewing this after I'm back!

Tinche commented 11 months ago

I want to get the next release out so I fixed this myself. Thanks!