Support 't' specifier in keywords

[jeanas]

Fixes #1014

[jeanas]

Note that there is a test for parse_keywords but no test for the actual extraction as I didn't really understand how that was supposed to be tested. There seems to be a mixture of pytest and unittest, setuptools integration and not. Which should I use? Or should I just write a test that exercises the inner function directly? Help is welcome.

[jeanas]

CI fails with a seemingly unrelated error.

[akx]

There seems to be a mixture of pytest and unittest, setuptools integration and not.

For new tests, prefer plain pytest style. Don't worry about the setuptools integration, it's... a bit of a mess.

Or should I just write a test that exercises the inner function directly? Help is welcome.

You can write a test that uses exercises the extraction function with a bespoke keywords directly, that's fine!

[jeanas]

(Rebasing on master)

[jeanas]

Thank you. I've added a test and fixed the bug that it caught.

tox -e py311 passes for me locally. I'm not sure what to do about the CI.

[jeanas]

Anything else needed?

[codecov[bot]]

Codecov Report

Merging #1015 (be33f02) into master (9ef53c6) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   90.91%   90.94%   +0.03%     
==========================================
  Files          25       25              
  Lines        4358     4375      +17     
==========================================
+ Hits         3962     3979      +17     
  Misses        396      396              

Files Changed	Coverage Δ
babel/messages/extract.py	95.31% <100.00%> (+0.12%)	:arrow_up:
babel/messages/frontend.py	87.61% <100.00%> (+0.20%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jeanas]

Thank you for your review, @akx. The PR should be improved quite a bit now, especially with regard to documentation and code clarity.

[jeanas]

@akx Gentle ping?

[akx]

@jeanas Sorry, I was on holiday and all that 😊

[jeanas]

A couple requests remaining. Thanks for your patience 😅

Now addressed.

[jeanas]

Ping?

[jeanas]

@akx Gentle ping.

[jeanas]

Thank you!