search

python-babel / babel

The official repository for Babel, the Python Internationalization Library
http://babel.pocoo.org/
BSD 3-Clause "New" or "Revised" License
1.29k stars 432 forks source link

Decouple `pybabel` frontend from distutils/setuptools; remove dependency #1041

Closed akx closed 7 months ago

akx commented 8 months ago

Fixes #1040

codecov[bot] commented 8 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (65de3dc) 89.82% compared to head (25467f9) 91.34%. Report is 1 commits behind head on master.

Files Patch % Lines
babel/messages/setuptools_frontend.py 60.00% 8 Missing :warning:
babel/messages/frontend.py 85.71% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1041 +/- ## ========================================== + Coverage 89.82% 91.34% +1.52% ========================================== Files 25 26 +1 Lines 4391 4415 +24 ========================================== + Hits 3944 4033 +89 + Misses 447 382 -65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akx commented 8 months ago

Cc @sigma67 @oprypin if you want to take a review-y look! :)

akx commented 7 months ago

@oprypin Could you review this too? :)

oprypin commented 7 months ago

@akx OK hopefully I'll get to it today. If I don't, then let's skip my review

oprypin commented 7 months ago

Also checked that MkDocs' setup.py integration (before it was removed) works with this change (also with my suggested edit)