Closed tomasr8 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.31%. Comparing base (
f91754b
) to head (efea1fe
). Report is 8 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #1124
Previously, the
Catalog.obsolete
dictionary would use themsgid
as a key to store messages. When there are two messages with the same id but a different context, the latter one overwrites the former.The fix is to use
Catalog._get_key
as the key, same as for_messages
.This might be considered a breaking change, however the only documentation for
Catalog.obsolete
is this:The docs never say anything about how the keys are computed, so I think it should be safe to make this change (and perhaps document it too?)