Closed tomasr8 closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.28%. Comparing base (
f1c8633
) to head (640926c
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looking at the release notes,
Added
alt='official'
to represent cases where an official value differs from the customary value.
may require changes in the importer (probably to ignore "official"
in favor of the customary value).
When upgrading the CLDR, I've generally run the importer with the -j
flag with the old CLDR so it zoops out human-readable JSON, move it aside, then do the same with the new CLDR and diff for interesting changes in languages I know in e.g. Beyond Compare or your other favorite diff tool.
Added units:
portion-per-1e9
(aka per-billion),night
(for hotel stays),light-speed
(as an internal prefix for light-second, light-minute, etc.)
Could be fun to see if (some of) these are supported in some locales and add some unit formatting tests for them.
The new emoji search stuff would also be nice to incorporate in some form (but that'd be a follow-up feature PR).
Looking at the release notes,
Added
alt='official'
to represent cases where an official value differs from the customary value.may require changes in the importer (probably to ignore
"official"
in favor of the customary value).
I'll try to see if there's some recommendation which value should be used in case both are present.
When upgrading the CLDR, I've generally run the importer with the
-j
flag with the old CLDR so it zoops out human-readable JSON, move it aside, then do the same with the new CLDR and diff for interesting changes in languages I know in e.g. Beyond Compare or your other favorite diff tool.
Thanks for the tip! I'll try that :)
Added units:
portion-per-1e9
(aka per-billion),night
(for hotel stays),light-speed
(as an internal prefix for light-second, light-minute, etc.)Could be fun to see if (some of) these are supported in some locales and add some unit formatting tests for them.
I'll check if there are any and try to add some tests
The new emoji search stuff would also be nice to incorporate in some form (but that'd be a follow-up feature PR).
Agreed, but yeah probably as a separate issue, I didn't really dig into that too much yet
The only alt="official"
that I found is in localeDisplayNames
:
<language type="mus">Muscogee</language>
<language type="mus" alt="official">Mvskoke</language>
We already ignore languages with the alt
attribute, but I added a test for it just in case.
Based on the discussion here, I think it's safe to keep using the customary value: https://unicode-org.atlassian.net/browse/CLDR-17761
I also added tests for the new units - I didn't know where to put them, so I created a new file test_units.py
for them.
Forgot to add, in the two locales I checked with the -j
flag, I didn't see any large differences besides the new units, some timezone updates and spelling changes.
CLDR 46 is out now, let's upgrade.
Looking at the release notes, I don't think there's anything we need to update in babel, but another pair of eyes would be nice :)