search

python-babel / babel

The official repository for Babel, the Python Internationalization Library
http://babel.pocoo.org/
BSD 3-Clause "New" or "Revised" License
1.29k stars 433 forks source link

Fix two issues with fuzzy matching #970

Closed jeanas closed 1 year ago

jeanas commented 1 year ago

Fixes #969

codecov[bot] commented 1 year ago

Codecov Report

Merging #970 (c8b7ac5) into master (08af5e2) will decrease coverage by 0.01%. The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
- Coverage   90.88%   90.88%   -0.01%     
==========================================
  Files          25       25              
  Lines        4333     4354      +21     
==========================================
+ Hits         3938     3957      +19     
- Misses        395      397       +2
Impacted Files Coverage Δ
babel/messages/catalog.py 95.26% <92.00%> (-0.27%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jeanas commented 1 year ago

Is the 0.01% coverage decrease something I should worry about?

jeanas commented 1 year ago

(Note that the two lines that don't have coverage are sanity check lines from the original difflib function that can't be triggered by babel because it uses the function correctly.)

akx commented 1 year ago

Is the 0.01% coverage decrease something I should worry about?

Not at all :)

jeanas commented 1 year ago

Thank you for taking the time.