search

python-babel / babel

The official repository for Babel, the Python Internationalization Library
http://babel.pocoo.org/
BSD 3-Clause "New" or "Revised" License
1.32k stars 440 forks source link

Makefile: use python3 instead of python #984

Closed bfontaine closed 1 year ago

bfontaine commented 1 year ago

Ubuntu doesn’t have a python executable; it’s either python2 or python3.

bfontaine commented 1 year ago

The failure seems to be unrelated:

C:\hostedtoolcache\windows\Python\3.10.10\x64\python3.exe: No module named pytest
  mingw[32](https://github.com/python-babel/babel/actions/runs/4315580116/jobs/7530168374#step:6:33)-make: *** [makefile:2: test] Error 1
  py310: exit 2 (9.42 seconds) D:\a\babel\babel> make clean-cldr test pid=6116
codecov[bot] commented 1 year ago

Codecov Report

Merging #984 (5dbc4be) into master (0ce196f) will decrease coverage by 1.37%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   90.94%   89.57%   -1.37%     
==========================================
  Files          25       25              
  Lines        4352     4356       +4     
==========================================
- Hits         3958     3902      -56     
- Misses        394      454      +60
Impacted Files Coverage Δ
babel/localtime/_win32.py 25.92% <0.00%> (-37.04%) :arrow_down:
babel/localtime/_helpers.py 42.30% <0.00%> (-19.24%) :arrow_down:
babel/support.py 76.95% <0.00%> (-8.37%) :arrow_down:
babel/localtime/__init__.py 75.00% <0.00%> (-8.34%) :arrow_down:
babel/dates.py 86.37% <0.00%> (-0.87%) :arrow_down:
babel/localedata.py 95.04% <0.00%> (-0.83%) :arrow_down:
babel/messages/frontend.py 86.64% <0.00%> (-0.75%) :arrow_down:
babel/core.py 96.54% <0.00%> (-0.29%) :arrow_down:
babel/messages/catalog.py 95.71% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

akx commented 1 year ago

The failure seems to be unrelated:

C:\hostedtoolcache\windows\Python\3.10.10\x64\python3.exe: No module named pytest

I don't think it is unrelated; that's not the tox-created virtualenv's python.

bfontaine commented 1 year ago

You’re right.

According to https://github.com/tox-dev/tox/issues/2801 on Windows you have to use python because python3 doesn’t exist, while on Debian (and so Ubuntu) you have to use python3 because python doesn’t exist. However, if you create a virtual environment with virtualenv or similar, you should have a python executable anyway, so this PR is not relevant.