Closed wjdp closed 4 years ago
A great many of these methods are just dumb wrappers around the babel method, passing the locale and the rest unchanged. I've been contemplating some alternatives to prevent us from having to maintain them. We could reflect all of the flask-babel bindings, checking the signature (inspect.getargspec
/inspect.signature
) of the babel method to see if it takes a locale
kwarg and fetching it if so.
Removing this method in favor of direct imports from babel in v2. See #164.
Babel have added
decimal_quantization
toformat_decimal
,format_currency
,format_percent
, andformat_scientific
. Flask-Babel cannot pass this arg through when using the equivalent proxy functions so users cannot use these new features.For reference here is Flask-Babel's
format_percent
And the signature of the underlying Babel function:
Should Flask-Babel hard code args in like this, or should it use the
*args, **kwargs
pattern to pass through extra args to the underlying Babel functions?