python-babel / flask-babel

i18n and l10n support for Flask based on Babel and pytz
https://python-babel.github.io/flask-babel/
Other
432 stars 159 forks source link

Port flask-babelex features to flask-babel #163

Closed ThiefMaster closed 3 years ago

ThiefMaster commented 4 years ago

Note: We have NOT tested it with any projects using the currently-released flask-babel version yet (so if anyone has such a project, doing so would be great). But the tests pass! ;)

@mrjoes do you want to be listed as a co-author in the commit that contains most of your babelex changes and/or somewhere in the copyright header? (if it's the latter, feel free to push a commit somewhere and we'll cherry-pick it into this PR)

mrjoes commented 4 years ago

This looks good, I will try this branch with flask-admin.

Re: credits - I'm fine either way.

TkTech commented 4 years ago

I hope to have time to review this on the weekend. Do you expect to push any more changes?

ThiefMaster commented 4 years ago

Sorry, I only noticed the second part of your comment now since there are no notifications about comments being edited. No plans to push more unless you insist on us updating the docs of course...

PS: Could you credit the flask-babelex author for originally contributing those features in whatever way you find most suitable when merging this?

mischkadb commented 4 years ago

Any update on this?