Closed ThiefMaster closed 3 years ago
This looks good, I will try this branch with flask-admin.
Re: credits - I'm fine either way.
I hope to have time to review this on the weekend. Do you expect to push any more changes?
Sorry, I only noticed the second part of your comment now since there are no notifications about comments being edited. No plans to push more unless you insist on us updating the docs of course...
PS: Could you credit the flask-babelex author for originally contributing those features in whatever way you find most suitable when merging this?
Any update on this?
Note: We have NOT tested it with any projects using the currently-released flask-babel version yet (so if anyone has such a project, doing so would be great). But the tests pass! ;)
@mrjoes do you want to be listed as a co-author in the commit that contains most of your babelex changes and/or somewhere in the copyright header? (if it's the latter, feel free to push a commit somewhere and we'll cherry-pick it into this PR)