Closed jwag956 closed 1 year ago
Our (flask-babel) call to get_translations()
is just a shortcut for get_domain().get_translations()
, see https://github.com/python-babel/flask-babel/blob/2a994898d989207043f06a859aec43bf510470ee/flask_babel/__init__.py#L207-L207. Unless I'm missing something here, this seems to be a non-issue as they are functionally identical
Specifics: As part of init_app(): Flask-BabelEx:
And Flask-Babel:
So Flask-Babel doesn't take into account the 'default domain' as specified in the init function.
Dialogue: This was never clear to me and and seems like a missing link with Flask* an Babel - how applications could have translations and messages and domains but still utilize 3rd party library translations and messages - seems like Domains wasn't really thought through (or I don't understand it!).
For Flask-Security - I have already introduced a library specific jinja function (_fsdomain) that me tag my templates to be translated not with the default domain but with a specific domain.
Anyway - this change will break many things - so at a minimum I would suggest a release note/documentation...