search

python-babel / flask-babel

i18n and l10n support for Flask based on Babel and pytz
https://python-babel.github.io/flask-babel/
Other
432 stars 159 forks source link

Fix check for presence of .mo file in translation directories #189

Closed ThiefMaster closed 3 years ago

ThiefMaster commented 3 years ago

In Python 2 the filter() worked because it returned a list, but in Python 3 it's a generator which is never falsy.

Note that, while a bugfix, this could break applications where someone relied on this bug. However, I think it's very unlikely so probably safe for a bugfix release.

ThiefMaster commented 3 years ago

BTW, you might want to enable the GitHub actions CI for PRs as well. Running tests only on push but not for PRs is a bit pointless ;)

TkTech commented 3 years ago

BTW, you might want to enable the GitHub actions CI for PRs as well. Running tests only on push but not for PRs is a bit pointless ;)

Once upon a time, new PRs made a push event for their commits. I'm not quite sure when this changed but it's bitten me in a couple of projects since I tend to copy-paste the template.

ThiefMaster commented 3 years ago

only if you don't use forks ;)