Open Paulholio opened 6 years ago
Hello,
Thanks for your contribution. A few things:
MapFields
, to be named like python's map()
builtin (but refers to "fields", as we could have a Map
that does this logic on a whole row)str.upper
as parameter to the transformation, so it allows to use any callable the same way. The usage would then be MapFields(str.upper)
, or MapFields(lambda val: ...)
, etc. Much more flexible and less error prone as we'll need less code.Thank you, this is a nice one !
I have this renamed to MapFields and will have users pass in a function. Still need to write a unit test.
This pull request introduces 1 alert when merging 166e846cc740e2a0e7008297095796c9269170be into ca464ef6f754c2e5bb7aa7632bb4190e6b39a037 - view on LGTM.com
new alerts:
Comment posted by LGTM.com
This is an attempt at eventually implementing the feature request from:
Issue 285: Updating All Fields
There is more work that needs to be done, but I think if we can spec out what types of operations we would want future users to be able to do across all fields, this can become very useful, especially on the validation and possibly security front. Let me know your opinions on this, please.