CsvWriter does not write headers

python-bonobo / bonobo

Extract Transform Load for Python 3.5+

https://www.bonobo-project.org/

Apache License 2.0

1.59k stars 146 forks source link

CsvWriter does not write headers #306

Closed joseph-holland closed 5 years ago

joseph-holland commented 5 years ago

Versions

Bonobo version: bonobo v.0.6.3
Python version: CPython 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 03:37:03) [MSC v.1900 64 bit (AMD64)]
Platform: MSYS_NT-10.0-WOW 2.10.0(0.325/5/3) 2018-06-13 23:18 i686 Msys

Issue

Output csv does not contain header line

Code to replicate:

def get_graph(**options):
    graph = bonobo.Graph()
    graph.add_chain(
        extract,
        transform,
        bonobo.CsvWriter('output.csv', fields=('header1', 'header2', 'header3', 'header4'))
    )
    return graph

joseph-holland commented 5 years ago

Hi,

I can see that this issue is already fixed in latest develop branch csv.py

  fields = context.get_input_fields() if self.fields is None else self.fields

Closing this issue.

Thanks, Joe