search

python-cachier / cachier

Persistent, stale-free, local and cross-machine caching for Python functions.
MIT License
534 stars 60 forks source link

ci: replace dead safety test with GH actions #177

Closed Borda closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (45143ae) 97.85% compared to head (06277e1) 59.76%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/python-cachier/cachier/pull/177/graphs/tree.svg?width=650&height=150&src=pr&token=fhsTDs7HL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier)](https://app.codecov.io/gh/python-cachier/cachier/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier) ```diff @@ Coverage Diff @@ ## master #177 +/- ## =========================================== - Coverage 97.85% 59.76% -38.09% =========================================== Files 6 6 Lines 512 512 Branches 96 96 =========================================== - Hits 501 306 -195 - Misses 10 191 +181 - Partials 1 15 +14 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/python-cachier/cachier/pull/177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/python-cachier/cachier/pull/177?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/python-cachier/cachier/pull/177?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). Last update [45143ae...06277e1](https://app.codecov.io/gh/python-cachier/cachier/pull/177?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier).
Borda commented 6 months ago

well, maybe drop it completely?

shaypal5 commented 6 months ago

Wait, leave this open. @Borda

I'm trying to solve this by dumping setup.py's install_requires contents into a temp requirements.txt file. safety check should then work.

Borda commented 6 months ago

I'm trying to solve this by dumping setup.py's install_requires contents into a temp requirements.txt file. safety check should then work.

ok, that would work too, so you are working on it or shall I append it here?

shaypal5 commented 6 months ago

It's done, and works locally. You're welcome to take it from here if the workflow needs fixes. I'm out for the day. @Borda

Borda commented 6 months ago

the name in action is strange https://github.com/aufdenpunkt/python-safety-check/issues/2#issuecomment-1944753504

shaypal5 commented 6 months ago

We don't want to rely on that action. A PR to fix that typo has been sitting there since March 2023 (!): https://github.com/aufdenpunkt/python-safety-check/pull/8

I forked and fixed the action, republishing it under a similar name: https://github.com/marketplace/actions/python-safety-checker

@Borda