python-cachier / cachier

Persistent, stale-free, local and cross-machine caching for Python functions.
MIT License
542 stars 60 forks source link

fix import after install #185

Closed Borda closed 8 months ago

Borda commented 8 months ago

turned out that while installing from a branch, the import was failing as the installed package were missing version.info file... this could not be discovered while pip install -e .


$ pip install https://github.com/python-cachier/cachier/archive/refs/heads/debug/install.zip
Defaulting to user installation because normal site-packages is not writeable
Collecting https://github.com/python-cachier/cachier/archive/refs/heads/debug/install.zip
  Downloading https://github.com/python-cachier/cachier/archive/refs/heads/debug/install.zip
     \ 44.1 kB 400.0 kB/s 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: watchdog in /home/jirka/.local/lib/python3.11/site-packages (from cachier==2.3.0.dev0) (3.0.0)
Requirement already satisfied: portalocker in /usr/lib/python3/dist-packages (from cachier==2.3.0.dev0) (1.5.1)
Requirement already satisfied: setuptools>=67.6.0 in /home/jirka/.local/lib/python3.11/site-packages (from cachier==2.3.0.dev0) (69.0.3)

[notice] A new release of pip is available: 23.3.1 -> 24.0
[notice] To update, run: python3.11 -m pip install --upgrade pip
$ python3.11 -c "import cachier"
fatal: not a git repository (or any of the parent directories): .git
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f0cc950) 97.85% compared to head (5aca56c) 97.85%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/python-cachier/cachier/pull/185/graphs/tree.svg?width=650&height=150&src=pr&token=fhsTDs7HL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier)](https://app.codecov.io/gh/python-cachier/cachier/pull/185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier) ```diff @@ Coverage Diff @@ ## master #185 +/- ## ======================================= Coverage 97.85% 97.85% ======================================= Files 6 6 Lines 512 512 Branches 96 96 ======================================= Hits 501 501 Misses 10 10 Partials 1 1 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/python-cachier/cachier/pull/185?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/python-cachier/cachier/pull/185?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). Last update [f0cc950...5aca56c](https://app.codecov.io/gh/python-cachier/cachier/pull/185?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-cachier).
shaypal5 commented 8 months ago

Let me know when this is ready for a review.

Borda commented 8 months ago

The fix is there and working correctly, just wanted to suppress the annoying message but that can be another PR...