date_search method is replaced

tobixen commented 1 year ago

One missing new-line. tox -e style should autocorrect that. And I should try and see if I can run the example test code. Except for that it's good to go.

yeshwantthota commented 1 year ago

One missing new-line. tox -e style should autocorrect that. And I should try and see if I can run the example test code. Except for that it's good to go.

One missing new-line. tox -e style should autocorrect that. And I should try and see if I can run the example test code. Except for that it's good to go.

I have added a new line

tobixen commented 1 year ago

Something broke when I was trying to run the basic_examples.py. I will check it up a bit later.

tobixen commented 1 year ago

Yes, forgot to say. The compfilter attribute is replaced by event=True or todo=True (and I should probably supplement it with `journal=True as well). If you add this (I could of course do it, but better you do it so we can have a nice commit log) we should be good:

--- a/examples/basic_usage_examples.py
+++ b/examples/basic_usage_examples.py
@@ -157,12 +157,11 @@ assert "FREQ=YEARLY" in todos[0].data
 print("Here is some more icalendar data:")
 print(todos[0].data)

-## date_search also works on task lists, but one has to be explicit to get them
+## date_search also works on task lists
 todos_found = my_new_tasklist.search(
     start=datetime(2021, 1, 1),
     end=datetime(2024, 1, 1),
-    compfilter="VTODO",
-    event=True,
+    todo=True,
     expand=True,
 )
 if not todos_found:

python-caldav / caldav

date_search method is replaced #236