python-caldav / caldav

Apache License 2.0
317 stars 94 forks source link

Check up that `event.copy` has sufficient test code #250

Closed tobixen closed 1 year ago

tobixen commented 1 year ago

ref https://github.com/home-assistant/core/pull/85536#issuecomment-1383034763 and https://github.com/home-assistant/core/actions/runs/3920550422/jobs/6702347492#step:10:8387

tobixen commented 1 year ago

Some observations:

event.parent should always be set to the calendar the event belongs to, so one question here is how it became unset ... hm.

One approach may be to try to throw in some asserts in the code, catching instances where event.parent is None and rerun the tests

tobixen commented 1 year ago

Closing this one. I threw in plenty of assert in a side-branch to pinpoint the problem. The problem was due to test code in the HomeAssistant creating an Event without a parent.