python-caldav / caldav

Apache License 2.0
314 stars 94 forks source link

Fix for issue #289 - basic auth broken towards some servers #290

Closed tobixen closed 1 year ago

tobixen commented 1 year ago

Background:

A bug was introduced in version 1.0, via https://github.com/python-caldav/caldav/pull/260 - the code would only work if there was a space in the WWW-Authenticate header. This works for most servers as they will challenge for credentials using a header like WWW-Authenticate: Basic realm="My CalDAV server" - however, WWW-Authenticate: Basic is fully allowed by RFC2617