python-caldav / caldav

Apache License 2.0
314 stars 94 forks source link

Fix #300 : enable huge_tree in XMLParser to handle very big events #301

Closed aaujon closed 1 year ago

aaujon commented 1 year ago

A proposition to fix https://github.com/python-caldav/caldav/issues/300 Activating huge_tree in XMLParser allow to handle very big caldav events.

aaujon commented 1 year ago

Tests are failing because rootdir is not the one I expected, fixed in new commit

tobixen commented 1 year ago

"tox -e style", and then it's ready?

tobixen commented 1 year ago

(the 80 character line length restriction in PEP-8 is a terrible constraint sometimes)

tobixen commented 1 year ago

Will you rebase it into one commit and press the "ready for review"-button? :-)

aaujon commented 1 year ago

All right, should be good now.

aaujon commented 1 year ago

Thanks for the review :)

tobixen commented 1 year ago

I can't promise a quick release of caldav v1.3.0 this time, but hopefully in a week or two.