search

python-caldav / caldav

Apache License 2.0
314 stars 94 forks source link

Don't forget to set `.davclient` in `DAVResponse` #323

Closed sobolevn closed 1 year ago

sobolevn commented 1 year ago

DAVResponse already has class-level davclient = None set, looks like it is not set on instance-level by accident.

tobixen commented 1 year ago

This classifies as a bugfix, though not a critical one since DAVResponse.davclient is not used anywhere. It's related to pull request #300. ~I think I will refactor a bit and replace DAVResponse.huge_tree with DAVResponse.davclient.huge_tree.~

Edited: I will leave things as they are - since self.davclient can be None, it's easier to just leave self.huge_tree as a separate instance variable.

tobixen commented 1 year ago

(hence I will not release any 1.3.7 today. 1.3.6 is still considered good)