python-caldav / caldav

Apache License 2.0
312 stars 91 forks source link

list comprehension would be redundant #404

Closed ArtemIsmagilov closed 3 weeks ago

ArtemIsmagilov commented 3 weeks ago

this version more productive and clearer)

tobixen commented 3 weeks ago

thank you. I hope to be able to do a new release this week.

tobixen commented 3 weeks ago

style test seems not to pass now.

tobixen commented 3 weeks ago

(I do agree that your revision looks nicer than the suggestion from the style test ... but we need those tests to pass)

tobixen commented 3 weeks ago

(perhaps it's possible to tune the test to be a bit more flexible when it comes to line breaking)

ArtemIsmagilov commented 3 weeks ago

ok, I want to finish this PR)

tobixen commented 3 weeks ago

Hmm ... I wonder why github doesn't offer to squash the commits into one commit ... or perhaps there is some button or menu thing I haven't seen. Would you care to run git rebase -i master, let your style commit be a fixup, and force-push?

ArtemIsmagilov commented 3 weeks ago

@tobixen, look, is squash option, web github buttons

ArtemIsmagilov commented 3 weeks ago

perhaps you are working through the desktop client github - maybe this functionality is not there

tobixen commented 3 weeks ago

I should probably turn off some "merge queue"-feature. I had expected that I would be able to approve merges, and then it would be merged after all the test code has succeeded - in reality it merges even with failed tests. Currently the only options I have is "Merge without waiting for requirements to be met (bypass branch protections)", "merge when ready" and "queue and merge in a group".

ArtemIsmagilov commented 3 weeks ago

Oк, got it

ArtemIsmagilov commented 3 weeks ago

@tobixen, Can you tell me which part of the file creates these dependencies? Why are they needed during development?

pip freeze
-e git+https://github.com/ArtemIsmagilov/caldav.git@3010eafa1471f3a310205c14f416af48324da18d#egg=caldav
caldav @ file:///home/artem/PycharmProjects/caldav
ArtemIsmagilov commented 3 weeks ago

looks like it's https://github.com/actions/cache