python-caldav / caldav

Apache License 2.0
312 stars 91 forks source link

why not grouping imports? #410

Closed ArtemIsmagilov closed 3 weeks ago

ArtemIsmagilov commented 3 weeks ago

you coding

from collections import defaultdict
from datetime import date
from datetime import datetime
from datetime import timedelta
from datetime import timezone
from typing import Any
from typing import Optional
from typing import Type
from typing import TypeVar
from typing import Union
from urllib.parse import ParseResult
from urllib.parse import quote
from urllib.parse import SplitResult
from urllib.parse import unquote
...

why not?

from collections import defaultdict
from datetime import date, datetime, timedelta, timezone
from typing import Any, Optional, Type, TypeVar, Union
from urllib.parse import ParseResult, quote, SplitResult, unquote
...
ArtemIsmagilov commented 3 weeks ago

we can add isort formatter, this package correct formatting imports

ArtemIsmagilov commented 3 weeks ago

I saw that you are already using another plugin to format imports https://github.com/asottile/reorder-python-imports

tobixen commented 3 weeks ago

I have no strong opinions on this. Someone introduced the "black style" to the project, and I've been sticking to that :-)