Closed ArtemIsmagilov closed 3 weeks ago
Some yaml linters demands that all yaml files starts with ----
https://stackoverflow.com/questions/50788277/why-3-dashes-hyphen-in-yaml-file
So it should stay as it is, I think :-)
Maybe this can be removed? Good to have a standard, but sometimes I like to annotate imports wih some # comments
. This automatic reordering of imports causes the comments to be moved away from the imports.
Aha ...
The style chosen by reorder-python-imports has a single aim: reduce merge conflicts.
So we'll keep it like it is.
@tobixen I would certainly recommend isort to you. You can take a look https://pycqa.github.io/isort/
Ага...
Стиль, выбранный reorder-python-imports, преследует единственную цель: уменьшить конфликты слияния.
Поэтому мы оставим все как есть.
I think this is a small part of what isort does. However, like any tool, these are just the choice and preference of the developer. As a maintainer, it's up to you to decide.
I am relatively indifferent. I don't know what's best from isort and the current sorting module. I can see that the risk of merge conflicts when grouping the imports together on the same line exists, but it's not a big thing. Another thing, when lots of things are to be imported, the 78 character limit gets in the way.
Perhaps I will change my mind at some point, but as for now I think we just keep it as it is.
I agree with you as long as you work as required. As we need something else, we will make new changes)
Another thing, when lots of things are to be imported, the 78 character limit gets in the way.
JFTR isort handles this.
removed unused line