Refactor `test_Blk_fake_osmosdr_source`

python-can-define-radio / pcdr

pcdr module: https://pypi.org/project/pcdr/

GNU General Public License v3.0

3 stars 1 forks source link

Refactor `test_Blk_fake_osmosdr_source` #60

Open james-pcdr opened 1 month ago

james-pcdr commented 1 month ago

test_Blk_fake_osmosdr_source() uses Blk_sink_print to capture the output of the Blk_fake_osmosdr_source. It works, but the code would be shorter and more readable if it used first_n_match(), as many of the other tests in that file do.

The goals:

Refactor this region to use first_n_match.
Erase the plotting portion of the test (it wasn't helping much anyway).

james-pcdr commented 1 month ago

@Elijah-cyber7 , I think this would be a good issue for you. Please feel free to let me know if you have questions and/or other preferences.

Elijah-cyber7 commented 1 month ago

This sounds good, I will get on it!

james-pcdr commented 1 month ago

You'll have to specify what it should equal. One way to make that is using pcdr.unstable.make_wave.

Two considerations:

Make sure the phase matches.
You might run into float precision issues. Feel free to change first_n_match to include a threshold argument, or look into pytest's options for approximate float comparison.

Note: I edited this comment to remove the email-reply junk at the bottom.