search

python-control / Slycot

Python wrapper for the Subroutine Library in Systems and Control Theory (SLICOT)
Other
132 stars 42 forks source link

Add sb10yd #203

Closed KybernetikJo closed 1 year ago

KybernetikJo commented 1 year ago

This Draft/PR adds the SLICOT Function SB10YD.f. A merge would close the issue #153.

It's working, following thing could be improved::

KybernetikJo commented 1 year ago

@bnavigator

How I get your force-push into my local and origin branch? I think I've done double work here.

bnavigator commented 1 year ago

It's alright, you did good. My force push was just a revert to (your) ddb8c03 because my attempt to resolve the merge conflict in 86032c8 had a mistake.

If there is a relevant change to your origin, you must merge or rebase your origin into your local before proceeding to push to origin.

bnavigator commented 1 year ago

Please rebase your feature branch onto master, there are some duplicate commits now

KybernetikJo commented 1 year ago

Yup, I have done something wrong. I will try to fix it.

bnavigator commented 1 year ago

I fixed some linting warning in the tests, mainly in order to trigger a new CI run with a new commit. Somehow 6ff1902 was not picked up by GitHub Actions.