python-control / Slycot

Python wrapper for the Subroutine Library in Systems and Control Theory (SLICOT)

Other

130 stars 42 forks source link

Time to release a new version? #98

Closed bnavigator closed 4 years ago

bnavigator commented 4 years ago

Hi,

with all the merged and pending PRs that would be ready to merge, I think it is warranted to take Slycot to the next release. For example, further development of https://github.com/python-control/python-control/pull/376 would need Slycot's support of complex matrices.

@roryyorke are you still around? Any other maintainer? I am also willing to help.

roryyorke commented 4 years ago

@moorepants yes please.

moorepants commented 4 years ago

I pushed it up.

bnavigator commented 4 years ago

:tada: yay!

For the next update (probably 0.4.1), could we please drop the fourth digit in the PyPI version? The git tag, the report during the CMake build and the .egg-info all report 0.4.0, but PyPI has 0.4.0.0.

moorepants commented 4 years ago

Conda forge package is in.

bnavigator commented 4 years ago

Conda forge package is in.

The tests will need a rework, though. On Linux and OS X the new test requirements for pytest and scipy are not being found. On Windows no tests are discovered.

moorepants commented 4 years ago

I suggest submitting a PR to the feedstock then. I am not familiar with the details of how the tests have changed.

This is the command that runs on the feedstock:

python -c "from slycot import test; test()"

If that doesn't run anymore, that seems like a backwards incompatibility.

bnavigator commented 4 years ago

python -c "from slycot import test; test()"
If that doesn't run anymore, that seems like a backwards incompatibility.

134, addressed in #136

roryyorke commented 4 years ago

I've sent a release notice to python-control-announce, so I think this is all done.

Thanks everyone!