Open kormoc opened 10 years ago
good idea @kormoc , i would suggest a more nuanced approach though: commit/push directly when you're pretty sure the commit is the right way forward and won't cause complaints, and still file PR's in case of doubt or if something might break compatibility.
Yeah, I love me my peer reviews as well. But we can now review each other's code Pada 30 Apr 2014 20:44, "Dieter Plaetinck" notifications@github.com menulis:
good idea @kormoc https://github.com/kormoc , i would suggest a more nuanced approach though: commit/push directly when you're pretty sure the commit is the right way forward and won't cause complaints, and still file PR's in case of doubt or if something might break compatibility.
— Reply to this email directly or view it on GitHubhttps://github.com/python-diamond/Diamond/issues/2#issuecomment-41797504 .
btw @kormoc if i were you, i would delete this repo, move brightcoveos/diamond to here, and then fork this back to brightcoveos/diamond; doing it via a move means issues, wiki, watchers, stars, etc get moved properly. and it's more clear which is the authorative upstream version and you can still maintain a fork for brightcove.
+1 on the transfer the repository
Sadly, I just can't :(
I've never worked for brightcove and ever contact I have there is gone. I've been unable to reach the right people to get you folks added directly to the repo as developers and I don't have the permissions to move the repo around. I'll keep trying, but I don't believe things will change.
I don't know how to handle git submodules well enough, but we should move the BrightcoveOS wiki to this repo, no?
@Lacrymology Done. :)
I can be a BC contact. @kormoc -- will contact you outside this issue.
@kormoc - I hope I'm not stealing this thread, but should issues and PRs be re-open against this repo?
Thanks.
@zstyblik you should issue PRs here
Thanks @mzupan, but that's not what I'm asking about. I'm asking whether issues and PRs from https://github.com/BrightcoveOS/Diamond should be re-opened here(and probably closed there).
Of course, I will open new issues and PRs here in the future.
@aronatkins @kormoc news on moving BrightcoveOS/Diamond here including issues/PR/etc as @Dieterbe suggested? that'd make things much more clear on what development to follow
thanks!
@kormoc I still have some contacts there. I'm sending you an email to the address listed on your github profile.
@ccope -- I hooked @kormoc up with Brian F. at Brightcove while I was still there. Brian's one of the BrightcoveOS admins. Not sure if that ever went anywhere. I've just left Brightcove myself, but can help still work to get the repo migrated if that's still needed. Feel free to CC me on anything.
Oh my, we have passing tests again!
@kormoc Thoughts on closing old PRs in the brightcove repo? And maybe changing the readme so that people stop referring to it?
@python-diamond/devs This is the best way I know to contact you folks. I really feel that Diamond is only successful due to all of your contributions and having no place to work together, we can't achieve as much as we could. I've given you guys commit access and hope you will directly work in the code base.
I'll keep merging code into the brightcove upstream repo, but my hope is eventually we'll move the authoritative upstream version to this group.
If you're not interested in commit access, please feel free to leave the group and feel free to continue to send traditional pull requests.
If you are interested in committing, please commit away and feel free to take an interest in any area of the code.
Thanks!