search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

uniform collectors file permissions #400

Open sandrotosi opened 8 years ago

sandrotosi commented 8 years ago

here is a summary of the permissions of the collector python files:

  [-rw-------]  src/collectors/amavis/amavis.py
  [-rw-r--r--]  src/collectors/apcupsd/apcupsd.py
  [-rw-------]  src/collectors/aurora/aurora.py
  [-rw-r--r--]  src/collectors/beanstalkd/beanstalkd.py
  [-rw-r--r--]  src/collectors/bind/bind.py
  [-rw-r--r--]  src/collectors/celerymon/celerymon.py
  [-rw-r--r--]  src/collectors/ceph/ceph.py
  [-rw-r--r--]  src/collectors/cephstats/cephstats.py
  [-rw-r--r--]  src/collectors/chronyd/chronyd.py
  [-rw-r--r--]  src/collectors/conntrack/conntrack.py
  [-rw-r--r--]  src/collectors/cpu/cpu.py
  [-rw-r--r--]  src/collectors/cpuacct_cgroup/cpuacct_cgroup.py
  [-rw-r--r--]  src/collectors/darner/darner.py
  [-rw-r--r--]  src/collectors/diskspace/diskspace.py
  [-rw-------]  src/collectors/disktemp/disktemp.py
  [-rw-r--r--]  src/collectors/diskusage/diskusage.py
  [-rw-r--r--]  src/collectors/drbd/drbd.py
  [-rw-r--r--]  src/collectors/dropwizard/dropwizard.py
  [-rw-r--r--]  src/collectors/dseopscenter/dseopscenter.py
  [-rwxr-xr-x]  src/collectors/elasticsearch/elasticsearch.py
  [-rw-------]  src/collectors/elb/elb.py
  [-rw-r--r--]  src/collectors/endecadgraph/endecadgraph.py
  [-rw-r--r--]  src/collectors/entropy/entropy.py
  [-rw-r--r--]  src/collectors/example/example.py
  [-rw-r--r--]  src/collectors/exim/exim.py
  [-rw-r--r--]  src/collectors/files/files.py
  [-rw-r--r--]  src/collectors/filestat/filestat.py
  [-rw-r--r--]  src/collectors/flume/flume.py
  [-rw-r--r--]  src/collectors/gridengine/gridengine.py
  [-rw-r--r--]  src/collectors/hadoop/hadoop.py
  [-rw-r--r--]  src/collectors/haproxy/haproxy.py
  [-rw-r--r--]  src/collectors/hbase/hbase.py
  [-rw-r--r--]  src/collectors/http/http.py
  [-rw-r--r--]  src/collectors/httpd/httpd.py
  [-rw-------]  src/collectors/httpjson/httpjson.py
  [-rw-r--r--]  src/collectors/icinga_stats/icinga_stats.py
  [-rw-r--r--]  src/collectors/interrupt/interrupt.py
  [-rw-r--r--]  src/collectors/interrupt/soft.py
  [-rw-r--r--]  src/collectors/iodrivesnmp/iodrivesnmp.py
  [-rw-r--r--]  src/collectors/ip/ip.py
  [-rw-r--r--]  src/collectors/ipmisensor/ipmisensor.py
  [-rw-r--r--]  src/collectors/ipvs/ipvs.py
  [-rw-r--r--]  src/collectors/jbossapi/jbossapi.py
  [-rw-r--r--]  src/collectors/jcollectd/collectd_network.py
  [-rw-r--r--]  src/collectors/jcollectd/jcollectd.py
  [-rw-------]  src/collectors/jolokia/cassandra_jolokia.py
  [-rw-r--r--]  src/collectors/jolokia/jolokia.py
  [-rw-r--r--]  src/collectors/kafkastat/kafkastat.py
  [-rw-r--r--]  src/collectors/ksm/ksm.py
  [-rw-r--r--]  src/collectors/kvm/kvm.py
  [-rw-r--r--]  src/collectors/libvirtkvm/libvirtkvm.py
  [-rw-r--r--]  src/collectors/lmsensors/lmsensors.py
  [-rw-r--r--]  src/collectors/loadavg/loadavg.py
  [-rw-r--r--]  src/collectors/memcached/memcached.py
  [-rw-r--r--]  src/collectors/memory/memory.py
  [-rw-r--r--]  src/collectors/memory_cgroup/memory_cgroup.py
  [-rw-r--r--]  src/collectors/memory_docker/memory_docker.py
  [-rw-r--r--]  src/collectors/memory_lxc/memory_lxc.py
  [-rw-------]  src/collectors/mesos/mesos.py
  [-rw-r--r--]  src/collectors/mongodb/mongodb.py
  [-rw-r--r--]  src/collectors/monit/monit.py
  [-rwxr-xr-x]  src/collectors/mountstats/mountstats.py
  [-rw-r--r--]  src/collectors/mysqlstat/mysql55.py
  [-rw-r--r--]  src/collectors/mysqlstat/mysqlstat.py
  [-rw-r--r--]  src/collectors/nagios/nagios.py
  [-rw-r--r--]  src/collectors/nagiosperfdata/nagiosperfdata.py
  [-rw-r--r--]  src/collectors/netapp/netappDisk.py
  [-rw-r--r--]  src/collectors/netapp/netapp_inode.py
  [-rw-r--r--]  src/collectors/netapp/netapp.py
  [-rw-r--r--]  src/collectors/netscalersnmp/netscalersnmp.py
  [-rw-r--r--]  src/collectors/network/network.py
  [-rw-r--r--]  src/collectors/nfacct/nfacct.py
  [-rw-r--r--]  src/collectors/nfs/nfs.py
  [-rw-r--r--]  src/collectors/nfsd/nfsd.py
  [-rw-r--r--]  src/collectors/nginx/nginx.py
  [-rw-r--r--]  src/collectors/ntpd/ntpd.py
  [-rw-r--r--]  src/collectors/numa/numa.py
  [-rw-r--r--]  src/collectors/onewire/onewire.py
  [-rw-r--r--]  src/collectors/openldap/openldap.py
  [-rw-r--r--]  src/collectors/openstackswift/openstackswift.py
  [-rw-r--r--]  src/collectors/openstackswiftrecon/openstackswiftrecon.py
  [-rw-r--r--]  src/collectors/openvpn/openvpn.py
  [-rw-r--r--]  src/collectors/ossec/ossec.py
  [-rw-r--r--]  src/collectors/passenger_stats/passenger_stats.py
  [-rw-r--r--]  src/collectors/pgbouncer/pgbouncer.py
  [-rw-r--r--]  src/collectors/pgq/pgq.py
  [-rw-r--r--]  src/collectors/phpfpm/phpfpm.py
  [-rw-r--r--]  src/collectors/ping/ping.py
  [-rw-r--r--]  src/collectors/portstat/portstat.py
  [-rw-r--r--]  src/collectors/postfix/postfix.py
  [-rw-------]  src/collectors/postgres/postgres.py
  [-rw-r--r--]  src/collectors/postqueue/postqueue.py
  [-rw-r--r--]  src/collectors/powerdns/powerdns.py
  [-rw-r--r--]  src/collectors/proc/proc.py
  [-rw-r--r--]  src/collectors/processresources/processresources.py
  [-rw-r--r--]  src/collectors/puppetagent/puppetagent.py
  [-rw-r--r--]  src/collectors/puppetdashboard/puppetdashboard.py
  [-rw-r--r--]  src/collectors/puppetdb/puppetdb.py
  [-rw-------]  src/collectors/rabbitmq/rabbitmq.py
  [-rw-r--r--]  src/collectors/redisstat/redisstat.py
  [-rw-r--r--]  src/collectors/resqueweb/resqueweb.py
  [-rw-r--r--]  src/collectors/s3/s3.py
  [-rw-r--r--]  src/collectors/scribe/scribe.py
  [-rw-r--r--]  src/collectors/servertechpdu/servertechpdu.py
  [-rw-r--r--]  src/collectors/sidekiqweb/sidekiqweb.py
  [-rw-r--r--]  src/collectors/slabinfo/slabinfo.py
  [-rw-r--r--]  src/collectors/slony/slony.py
  [-rw-r--r--]  src/collectors/smart/smart.py
  [-rw-r--r--]  src/collectors/snmp/snmp.py
  [-rw-r--r--]  src/collectors/snmpinterface/snmpinterface.py
  [-rw-r--r--]  src/collectors/snmpraw/snmpraw.py
  [-rw-r--r--]  src/collectors/sockstat/sockstat.py
  [-rw-r--r--]  src/collectors/solr/solr.py
  [-rw-r--r--]  src/collectors/sqs/sqs.py
  [-rw-r--r--]  src/collectors/squid/squid.py
  [-rw-r--r--]  src/collectors/supervisord/supervisord.py
  [-rw-r--r--]  src/collectors/tcp/tcp.py
  [-rw-r--r--]  src/collectors/tokumx/tokumx.py
  [-rw-------]  src/collectors/twemproxy/twemproxy.py
  [-rw-r--r--]  src/collectors/udp/udp.py
  [-rw-r--r--]  src/collectors/unbound/unbound.py
  [-rw-r--r--]  src/collectors/ups/ups.py
  [-rw-r--r--]  src/collectors/uptime/uptime.py
  [-rw-r--r--]  src/collectors/users/users.py
  [-rw-r--r--]  src/collectors/userscripts/userscripts.py
  [-rw-r--r--]  src/collectors/varnish/varnish.py
  [-rw-r--r--]  src/collectors/vmsdoms/vmsdoms.py
  [-rw-r--r--]  src/collectors/vmsfs/vmsfs.py
  [-rw-r--r--]  src/collectors/vmstat/vmstat.py
  [-rw-r--r--]  src/collectors/websitemonitor/websitemonitor.py
  [-rw-r--r--]  src/collectors/xen_collector/xen_collector.py
  [-rw-r--r--]  src/collectors/zookeeper/zookeeper.py

it might make sense to make them all 644, in particular src/collectors/elasticsearch/elasticsearch.py and src/collectors/mountstats/mountstats.py should be chmod -x

josegonzalez commented 7 years ago

Seems reasonable. I think doing this now might cause tons of merge conflicts, though I'll have to do some research.