python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

Debian install failed #623

Closed m-messiah closed 6 years ago

m-messiah commented 7 years ago

After commit: https://github.com/python-diamond/Diamond/commit/65f83ee95e965365c4e3231b8ec65fd4c09f2ee8 Diamond tries to find python-configobj package, which is absent (cause it finds in PIP, not apt-cache), so Diamond install fails after that version.

shortdudey123 commented 7 years ago

Looks like the bug that was being fixed was introduced over 3 yrs ago in https://github.com/python-diamond/Diamond/commit/87197fdab55ed86a450de6fc41957e7e9dd31fef and never worked. Probably can just yank that entire if statement

DStape commented 6 years ago

Hi @m-messiah,

This was reported over a year ago - is this issue still present?

Installing diamond as a debian package should now be pulling in python-configobj due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824228.

m-messiah commented 6 years ago

Hi @DStape ,

I have just checked at jessie and stretch - both works now.

DStape commented 6 years ago

Thanks @m-messiah