Closed rksatyam closed 7 years ago
Full disclosure: @rksatyam work together in our current company and discussed this change.
@shortdudey123: This change seems reasonable to me. I spoke to @rksatyam and he has done manual verification by killing the process to get this to trigger. I'm not sure it's easy to test given the current diamond testing framework.
If you're otherwise good with it, let's pull it in.
@jaingaurav cool, just wanted another set of eyes since this is core code :)
The main diamond process takes care of the exited collectors but doesn't really take care of the exited handlers. This caused a problem for us where we weren't getting the stats. If the whole process had exited, the full diamond process could have got restarted by the svc daemon. Hence, created an option to allow aborting when the handlers process exits and in that case it just exits.
Tested the option by manually killing the Handlers process and ensuring that the diamond process exits when the option is true and not otherwise.