python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

JolokiaCollector collects all mbeans regardless of mbeans argument configuration #645

Open alekiv opened 7 years ago

alekiv commented 7 years ago

From documentation: mbeans argument - Pipe delimited list of MBeans for which to collect stats. If not provided, all stats will be collected.

Actually collector collects all mbeans regardless of configured mbeans. "mbeans" list or regex is used just for filtering out actual mbeans from big list of domain obj. It becomes problem with CassandraJolokiaCollector, since there are much data in JMX and diamond just can't get all data in reasonable time.

Proposal: change Jolokia collector logic and read specified mbeans only if "mbeans" list is set, instead of reading domains all data

shortdudey123 commented 1 year ago

Feel free to submit a PR.