Handle Riemann errors gracefully

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.

http://diamond.readthedocs.org/

MIT License

1.74k stars 601 forks source link

Handle Riemann errors gracefully #659

Closed mahendra closed 1 year ago

mahendra commented 7 years ago

The riemann handler does not handle server side disconnects gracefully. If the riemann server is restarted, diamond does not reconnect to the server.

coveralls commented 7 years ago

Coverage increased (+0.009%) to 24.676% when pulling 7baf0dcb77abe633d5b4e81ca4ef320029ab5502 on Affirm:master into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

keyboardfann commented 7 years ago

Hi @mahendra , Does the patch still not merge into the master branch?

Fann

shortdudey123 commented 1 year ago

I am going to close this since there has been way more commits beyond the original scope of the PR. Feel free to pull the relevant commits into a new PR.